| {% trans "Last name" %} | +{% trans "First name" %} | +{% trans "Email" %} | +{% trans "Type" %} | ++ |
|---|---|---|---|---|
| {{ person.last_name }} | +{{ person.first_name }} | +{{ person.contact_email|default:"-" }} | ++ {% if is_club_admin %} + + {% else %} + {{ person.role_in_family_display|capfirst }} + {% endif %} + | +
+ {% if is_club_admin %}
+
+ {% if person.grant_login_form %}
+
+ {% endif %}
+ {% lucide "pencil" size=14 %} {% trans "Edit" %}
+
+
+
+ {% endif %}
+ |
+
| {{ object }} | +
| {% trans "Nothing here yet." %} | +
| {{ event.start|date:"D j M, H:i" }} | +{{ event.title }} | +{{ event.get_kind_display|capfirst }} | +
| {% trans "Nothing scheduled." %} | +
{% trans "New members against returning ones." %}
+{% trans "Not rostered for the current season." %}
+ {% endif %} + + {% if membership_history %} + +| {% trans "Season" %} | +{% trans "Status" %} | +{% trans "Fee status" %} | +{% trans "License" %} | +
|---|---|---|---|
| {{ membership.season.start_date|date:"Y" }} - {{ membership.season.end_date|date:"Y" }} | +{{ membership.get_status_display }} | +{{ membership.get_fee_status_display }} | +{{ membership.license|default:"-" }} | +
{% trans "Not part of a family." %}
+ {% endif %} ++ {% blocktrans %}Fill in the downloaded template — one row per member — then upload it + here. Nothing is created yet: you'll see exactly what will be added + before anything is saved.{% endblocktrans %} +
+ + ++ {% blocktrans count counter=valid_count %}{{ counter }} member will be created.{% plural %}{{ counter }} members will be created.{% endblocktrans %} + {% if skipped_count %}{% blocktrans count counter=skipped_count %}{{ counter }} row will be skipped.{% plural %}{{ counter }} rows will be skipped.{% endblocktrans %}{% endif %} +
+ +| {% trans "Row" %} | +{% trans "Last name" %} | +{% trans "First name" %} | +{% trans "Email" %} | +{% trans "Outcome" %} | +
|---|---|---|---|---|
| {{ result.line_number }} | +{{ result.raw.last_name }} | +{{ result.raw.first_name }} | +{{ result.raw.email }} | +
+ {% if result.member %}
+ {% trans "Will create" %}
+ {% else %}
+ {% trans "Skipped" %}
+ {{ result.errors|join:"; " }}
+ {% endif %}
+ |
+
| {% trans "No rows found in the uploaded file." %} | +||||
| {% trans "Last name" %} | +{% trans "First name" %} | +{% trans "Email" %} | +{% trans "Family" %} | +{% trans "Status" %} | ++ |
|---|---|---|---|---|---|
| {{ member.last_name }} | +{{ member.first_name }} | +{{ member.contact_email|default:"-" }} | +
+ {% if member.family_memberships_display %}
+
+ {% for fm in member.family_memberships_display %}
+
+ {% endfor %}
+
+ {% else %}
+ -
+ {% endif %}
+ |
+ + {% if member.current_membership %} + + {{ member.current_membership.get_status_display }} + + {% else %} + {% trans "unknown" %} + {% endif %} + | ++ {% if is_club_admin %} + + {% endif %} + | +
| {% trans "No members yet." %} | +|||||
| {% trans "Last name" %} | +{% trans "First name" %} | +{% trans "Email" %} | +{% trans "Family" %} | +{% trans "Status" %} | +{% trans "Fee status" %} | +{% trans "Owed" %} | +{% trans "Paid" %} | +{% trans "License" %} | +
|---|---|---|---|---|---|---|---|---|
| {{ membership.member.last_name }} | +{{ membership.member.first_name }} | +{{ membership.member.contact_email|default:"—" }} | ++ {% for fm in membership.member.family_memberships_display %}{{ fm.family }}{% if not forloop.last %}, {% endif %}{% empty %}—{% endfor %} + | ++ {{ membership.get_status_display }} + | ++ {{ membership.get_fee_status_display }} + | +{{ membership.fee_amount }} | +{{ membership.amount_paid }} | +{{ membership.license|default:"—" }} | +
| {% trans "Nobody matches these filters." %} | +||||||||
| {% trans "Member" %} | +{% trans "Role" %} | ++ |
|---|---|---|
| {{ role.member }} | +{{ role.get_role_display }} | ++ + | +
| {% trans "No roles granted yet." %} | +||
{% trans "Roster and staff assignments for this team are managed from the Roster and Staff sections." %}
+| {% trans "Name" %} | +{% trans "Short name" %} | +
|---|---|
| {{ team.name }} | +{{ team.short_name }} | +
| {% trans "No teams yet." %} | +|
hi
"), b"%PDF-1.7") + + def test_a_missing_pdf_library_says_what_is_missing(self): + with mock.patch.dict(sys.modules, {"weasyprint": None}), self.assertRaises(PDFExportError): + render_pdf("hi
") + + +class MembershipExportPdfTests(ManagementTestBase): + def setUp(self): + super().setUp() + self.client.force_login(self.admin_user) + self.member = Member.objects.create(first_name="Print", last_name="Me") + ClubMembership.objects.create(club=self.club, member=self.member, season=self.season, status=ClubMembership.StatusChoices.ACTIVE, fee_status=ClubMembership.FeeStatus.UNPAID) + + def test_downloads_as_a_pdf(self): + with mock.patch("management.views.membership_list_pdf", return_value=b"%PDF-fake") as renderer: + response = self.club_get("membership_export_pdf") + + self.assertEqual(response["Content-Type"], "application/pdf") + self.assertIn(".pdf", response["Content-Disposition"]) + self.assertEqual(response.content, b"%PDF-fake") + renderer.assert_called_once() + + def test_export_uses_the_same_filters_as_the_page(self): + # Same fixture as the "on-team" filter test for the page itself -- the PDF + # must reflect whatever's filtered, not the whole club. + other = Member.objects.create(first_name="Other", last_name="Person") + ClubMembership.objects.create(club=self.club, member=other, season=self.season, status=ClubMembership.StatusChoices.ACTIVE, fee_status=ClubMembership.FeeStatus.UNPAID) + + with mock.patch("management.views.membership_list_pdf", return_value=b"%PDF-fake") as renderer: + self.client.get(reverse("management:membership_export_pdf") + "?q=Print", HTTP_HOST="ajax-united.rosterchief.app") + + context = renderer.call_args[0][0] + names = {m.member.last_name for m in context["memberships"]} + self.assertEqual(names, {"Me"}) + + def test_a_missing_pdf_library_is_reported_rather_than_a_500(self): + # WeasyPrint needs native libs. Without them the button must explain itself. + with mock.patch("management.views.membership_list_pdf", side_effect=PDFExportError("PDF rendering needs the native pango/cairo libraries.")): + response = self.club_get("membership_export_pdf") + response = self.client.get(response.url, HTTP_HOST="ajax-united.rosterchief.app") + + self.assertContains(response, "pango") + + def test_non_admin_gets_403(self): + coach_user = User.objects.create_user(email="coach-export@example.com", password="pw-secret-123") + coach_member = Member.objects.create(user=coach_user, first_name="Cara", last_name="Coach") + team = Team.objects.create(club=self.club, name="U21", short_name="U21") + position = Position.objects.create(club=self.club, name="Coach10", short_name="C10", staff_position=True) + StaffAssignment.objects.create(team=team, member=coach_member, season=self.season, position=position) + self.client.force_login(coach_user) + + response = self.club_get("membership_export_pdf") + + self.assertEqual(response.status_code, 403) + + +class MemberListRowActionsTests(ManagementTestBase): + def setUp(self): + super().setUp() + self.member = Member.objects.create(first_name="Row", last_name="Actions") + ClubMembership.objects.create(club=self.club, member=self.member, season=self.season, status=ClubMembership.StatusChoices.ACTIVE) + + def test_admin_sees_edit_and_delete_buttons(self): + self.client.force_login(self.admin_user) + + response = self.club_get("member_list") + + self.assertContains(response, reverse("management:member_delete", args=[self.member.pk])) + + def test_non_admin_does_not_see_edit_and_delete_buttons(self): + # Roster self.member on the coach's team so this actually tests the + # admin-only button gating, not just "the coach can't see this row at all". + coach_user = User.objects.create_user(email="coach5@example.com", password="pw-secret-123") + coach_member = Member.objects.create(user=coach_user, first_name="Cara", last_name="Coach") + team = Team.objects.create(club=self.club, name="U16", short_name="U16") + staff_position = Position.objects.create(club=self.club, name="Coach5", short_name="C5", staff_position=True, management_position=True) + player_position = Position.objects.create(club=self.club, name="Player5", short_name="P5", staff_position=False) + StaffAssignment.objects.create(team=team, member=coach_member, season=self.season, position=staff_position) + TeamMembership.objects.create(team=team, member=self.member, season=self.season, position=player_position) + self.client.force_login(coach_user) + + response = self.club_get("member_list") + + self.assertContains(response, "Row") + self.assertNotContains(response, reverse("management:member_delete", args=[self.member.pk])) + + +class HomeViewTests(ManagementTestBase): + """The dashboard reuses controlpanel.services.statistics' club_attention/ + club_charts/club_statistics -- already club-scoped, so directly usable for this + club's own staff. Financial pieces (fee chart, Shop stat group) are admin-only, + same line the nav already draws around the Shop section.""" + + def make_coach(self, email): + coach_user = User.objects.create_user(email=email, password="pw-secret-123") + coach_member = Member.objects.create(user=coach_user, first_name="Cara", last_name="Coach") + team = Team.objects.create(club=self.club, name=f"Team-{email}", short_name="T") + position = Position.objects.create(club=self.club, name=f"Coach-{email}", short_name="C", staff_position=True, management_position=True) + StaffAssignment.objects.create(team=team, member=coach_member, season=self.season, position=position) + return coach_user + + def test_admin_sees_the_financial_sections(self): + self.client.force_login(self.admin_user) + + response = self.club_get("home") + + self.assertEqual(response.status_code, 200) + self.assertContains(response, 'id="fees-chart"') + self.assertContains(response, "Open carts") + + def test_non_admin_staff_does_not_see_the_financial_sections(self): + self.client.force_login(self.make_coach("coach6@example.com")) + + response = self.club_get("home") + + self.assertEqual(response.status_code, 200) + self.assertNotContains(response, 'id="fees-chart"') + self.assertNotContains(response, "Open carts") + + def test_upcoming_events_are_listed_in_order_and_future_only(self): + now = timezone.now() + past = Event.objects.create(club=self.club, kind=Event.EventKind.TRAINING, title="Past training", start=now - datetime.timedelta(days=1)) + soon = Event.objects.create(club=self.club, kind=Event.EventKind.TRAINING, title="Sooner training", start=now + datetime.timedelta(days=1)) + later = Event.objects.create(club=self.club, kind=Event.EventKind.MATCH, title="Later match", start=now + datetime.timedelta(days=5)) + self.client.force_login(self.admin_user) + + response = self.club_get("home") + + body = response.content.decode() + self.assertNotIn(past.title, body) + self.assertLess(body.index(soon.title), body.index(later.title)) + + def test_loads_fine_with_no_season_and_no_events(self): + # A fresh club, never given a season -- ClubMembership.season is PROTECT, so + # this is a new club rather than deleting self.season out from under setUp's + # own ClubMembership. + empty_club = Club.objects.create(name="Empty FC", slug="empty-fc") + admin_member = Member.objects.create(first_name="Empty", last_name="Admin") + ClubRole.objects.create(club=empty_club, member=admin_member, role=ClubRole.Roles.ADMIN) + admin_user = User.objects.create_user(email="emptyadmin@example.com", password="pw-secret-123") + admin_member.user = admin_user + admin_member.save() + enrol_mfa(admin_user) + self.client.force_login(admin_user) + + with override_settings(ALLOWED_HOSTS=["rosterchief.app", "ajax-united.rosterchief.app", "empty-fc.rosterchief.app", "testserver"]): + response = self.client.get(reverse("management:home"), HTTP_HOST="empty-fc.rosterchief.app") + + self.assertEqual(response.status_code, 200) + self.assertContains(response, "cannot take a signup") + self.assertContains(response, "Nothing scheduled.") + + +class MemberBulkImportTests(ManagementTestBase): + def setUp(self): + super().setUp() + self.client.force_login(self.admin_user) + + def make_non_admin_staff(self): + coach_user = User.objects.create_user(email="coach-import@example.com", password="pw-secret-123") + coach_member = Member.objects.create(user=coach_user, first_name="Cara", last_name="Coach") + team = Team.objects.create(club=self.club, name="U14", short_name="U14") + position = Position.objects.create(club=self.club, name="CoachImport", short_name="CI", staff_position=True) + StaffAssignment.objects.create(team=team, member=coach_member, season=self.season, position=position) + return coach_user + + def test_template_download_has_expected_headers_and_dropdowns(self): + response = self.club_get("member_import_template") + + self.assertEqual(response.status_code, 200) + self.assertEqual(response["Content-Type"], XLSX_CONTENT_TYPE) + + workbook = openpyxl.load_workbook(BytesIO(response.content)) + sheet = workbook.active + header = [cell.value for cell in sheet[1]] + self.assertEqual(header, TEMPLATE_COLUMNS) + self.assertTrue(sheet.data_validations.dataValidation) + + def test_non_admin_can_download_template_but_not_upload(self): + coach_user = self.make_non_admin_staff() + self.client.force_login(coach_user) + + template_response = self.club_get("member_import_template") + upload_response = self.club_post("member_import", {"file": make_import_workbook([["Jamie", "Kid", "", "jamie@example.com", "", "", "", "", ""]])}) + + self.assertEqual(template_response.status_code, 200) + self.assertEqual(upload_response.status_code, 403) + + def test_anonymous_is_redirected_to_login_for_both(self): + self.client.logout() + + self.assertEqual(self.club_get("member_import_template").status_code, 302) + self.assertEqual(self.club_get("member_import").status_code, 302) + + def test_a_clean_row_previews_as_will_create(self): + upload = make_import_workbook([["Jamie", "Kid", "2010-01-01", "jamie.kid@example.com", "+32470111111", "", "", "", ""]]) + + response = self.club_post("member_import", {"file": upload}) + + self.assertEqual(response.context["valid_count"], 1) + self.assertEqual(response.context["skipped_count"], 0) + result = response.context["results"][0] + self.assertIsNotNone(result["member"]) + self.assertEqual(result["membership_kwargs"]["status"], ClubMembership.StatusChoices.ACTIVE) + self.assertEqual(result["membership_kwargs"]["fee_status"], ClubMembership.FeeStatus.UNPAID) + + def test_a_row_missing_a_required_name_is_skipped(self): + upload = make_import_workbook([["", "Noname", "", "", "", "", "", "", ""]]) + + response = self.club_post("member_import", {"file": upload}) + + self.assertEqual(response.context["valid_count"], 0) + result = response.context["results"][0] + self.assertIsNone(result["member"]) + self.assertTrue(result["errors"]) + + def test_an_invalid_email_is_skipped(self): + upload = make_import_workbook([["Bad", "Email", "", "not-an-email", "", "", "", "", ""]]) + + response = self.club_post("member_import", {"file": upload}) + + result = response.context["results"][0] + self.assertIsNone(result["member"]) + + def test_an_invalid_status_value_is_skipped(self): + upload = make_import_workbook([["Bad", "Status", "", "bad.status@example.com", "", "", "", "not-a-status", ""]]) + + response = self.club_post("member_import", {"file": upload}) + + result = response.context["results"][0] + self.assertIsNone(result["member"]) + self.assertTrue(any("status" in error.lower() for error in result["errors"])) + + def test_a_duplicate_email_within_the_file_is_flagged_on_the_second_row(self): + upload = make_import_workbook( + [ + ["First", "Dup", "", "dup@example.com", "", "", "", "", ""], + ["Second", "Dup", "", "dup@example.com", "", "", "", "", ""], + ] + ) + + response = self.club_post("member_import", {"file": upload}) + + results = response.context["results"] + self.assertIsNotNone(results[0]["member"]) + self.assertIsNone(results[1]["member"]) + self.assertIn("Duplicate email in this file.", results[1]["errors"]) + + def test_an_email_already_in_the_club_is_skipped(self): + upload = make_import_workbook([["Ada", "Admin", "", self.admin_user.email, "", "", "", "", ""]]) + + response = self.club_post("member_import", {"file": upload}) + + result = response.context["results"][0] + self.assertIsNone(result["member"]) + self.assertIn("Already a member of this club.", result["errors"]) + + def test_confirm_creates_only_the_valid_rows_with_defaults(self): + upload = make_import_workbook( + [ + ["Jamie", "Kid", "2010-01-01", "jamie.kid@example.com", "", "", "LIC-1", "", ""], + ["", "Noname", "", "", "", "", "", "", ""], + ] + ) + self.club_post("member_import", {"file": upload}) + + response = self.club_post("member_import_confirm", {}) + + self.assertRedirects(response, reverse("management:member_list")) + member = Member.objects.get(email="jamie.kid@example.com") + membership = ClubMembership.objects.get(club=self.club, member=member) + self.assertEqual(membership.status, ClubMembership.StatusChoices.ACTIVE) + self.assertEqual(membership.fee_status, ClubMembership.FeeStatus.UNPAID) + self.assertEqual(membership.license, "LIC-1") + self.assertFalse(Member.objects.filter(last_name="Noname").exists()) + + def test_confirm_without_a_prior_upload_creates_nothing(self): + response = self.club_post("member_import_confirm", {}) + + self.assertRedirects(response, reverse("management:member_import")) + self.assertEqual(Member.objects.filter(last_name="Kid").count(), 0) + + def test_confirm_is_admin_only(self): + coach_user = self.make_non_admin_staff() + upload = make_import_workbook([["Jamie", "Kid", "", "jamie.kid2@example.com", "", "", "", "", ""]]) + self.club_post("member_import", {"file": upload}) + + self.client.force_login(coach_user) + response = self.club_post("member_import_confirm", {}) + + self.assertEqual(response.status_code, 403) diff --git a/management/urls.py b/management/urls.py new file mode 100644 index 0000000..b567e9f --- /dev/null +++ b/management/urls.py @@ -0,0 +1,56 @@ +from django.urls import path + +from . import views + +app_name = "management" + +urlpatterns = [ + path("", views.HomeView.as_view(), name="home"), + # People + path("members/", views.MemberListView.as_view(), name="member_list"), + path("memberships/", views.MembershipListView.as_view(), name="membership_list"), + path("memberships/mark-paid/", views.MembershipMarkPaidView.as_view(), name="membership_mark_paid"), + path("memberships/export/", views.MembershipExportPdfView.as_view(), name="membership_export_pdf"), + path("memberships/