bernard/RosterChief
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add spacing, a larger body, and photo uploads to the coach news form

Browse Source 
The post-composer screen was cramped and text-only, and its "audience"
picker exposed the same "which team(s)" choice the create-event screen
already dropped -- hard-lock teams to the coach's active team instead
(hidden field, required=True so a tampered empty submission can't
silently become club-wide), matching how CoachCreateEventView.teams
already works. Photos reuse management's own NewsPhotoUploadForm/
NewsPhoto machinery, first upload becomes the main picture.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Bernard Siebens
2026-08-23 17:47:49 +02:00
parent b9900510b1
commit 148f3a24c9
6 changed files with 125 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
mobile/tests.py
View File

@@ -3963,13 +3963,15 @@ class CoachCreateNewsViewTests(TestCase):
self.assertEqual(team_choices, [self.team])
self.assertNotIn(other_team, team_choices)
def test_teams_field_is_prechecked_with_the_active_team(self):
def test_teams_is_hidden_and_locked_to_the_active_team(self):
self.client.force_login(self.user)
response = self.client.get(reverse("mobile:coach_create_news"), HTTP_HOST="ajax-united.rosterchief.app")
self.assertIsInstance(response.context["form"].fields["teams"].widget, forms.MultipleHiddenInput)
self.assertEqual(response.context["form"].initial.get("teams"), [self.team.pk])
self.assertContains(response, f'value="{self.team.pk}" id="id_teams_0" checked')
self.assertContains(response, f'<input type="hidden" name="teams" value="{self.team.pk}"')
self.assertNotContains(response, 'name="teams" type="checkbox"')
def test_valid_post_creates_a_pending_review_post_scoped_to_the_team(self):
self.client.force_login(self.user)
@@ -3993,6 +3995,31 @@ class CoachCreateNewsViewTests(TestCase):
self.assertFalse(News.objects.filter(title="No team picked").exists())
self.assertTrue(response.context["form"].errors)
def test_photos_are_optional(self):
self.client.force_login(self.user)
response = self._post(title="No photos here")
self.assertRedirects(response, reverse("mobile:coach_today"), fetch_redirect_response=False)
news_item = News.objects.get(title="No photos here")
self.assertEqual(news_item.photos.count(), 0)
def test_uploaded_photos_are_attached_first_one_is_main(self):
self.client.force_login(self.user)
response = self.client.post(
reverse("mobile:coach_create_news"),
{"title": "Photo finish", "body": "Great game everyone.", "teams": [str(self.team.pk)], "images": [make_image_file("one.png"), make_image_file("two.png")]},
HTTP_HOST="ajax-united.rosterchief.app",
)
self.assertRedirects(response, reverse("mobile:coach_today"), fetch_redirect_response=False)
news_item = News.objects.get(title="Photo finish")
photos = list(news_item.photos.order_by("ordering"))
self.assertEqual(len(photos), 2)
self.assertTrue(photos[0].is_main)
self.assertFalse(photos[1].is_main)
def test_non_managing_staff_cannot_post(self):
physio_position = Position.objects.create(club=self.club, name="Physio", short_name="PHY", staff_position=True, management_position=False)
physio_user = User.objects.create_user(email="physio@example.com", password="pw-secret-123")