From 2c4d03105089f91295d853a201c83b90cc393bc5 Mon Sep 17 00:00:00 2001 From: Bernard Siebens Date: Mon, 3 Aug 2026 17:04:09 +0200 Subject: [PATCH] Show just surnames for an unnamed family, not "... family" An unnamed family with distinct member surnames read as "Jones / Smith family" -- dropping the suffix reads more like an actual family name. --- members/models.py | 2 +- members/tests.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/members/models.py b/members/models.py index d9499b3..27bcd37 100644 --- a/members/models.py +++ b/members/models.py @@ -19,7 +19,7 @@ class Family(UUIDModel): return self.name surnames = sorted({last_name for last_name in self.memberships.values_list("member__last_name", flat=True) if last_name}) if surnames: - return _("%(surnames)s family") % {"surnames": " / ".join(surnames)} + return _("%(surnames)s") % {"surnames": " / ".join(surnames)} return _("Family %(id)s") % {"id": str(self.pk)[:8]} @property diff --git a/members/tests.py b/members/tests.py index c794f48..aaa77fd 100644 --- a/members/tests.py +++ b/members/tests.py @@ -87,7 +87,7 @@ class FamilyNameOptionalTests(TestCase): FamilyMembership.objects.create(family=family, member=jones, role=FamilyMembership.FamilyRole.CHILD) # Distinct surnames, alphabetically ordered. - self.assertEqual(str(family), "Jones / Smith family") + self.assertEqual(str(family), "Jones / Smith") def test_str_falls_back_to_short_id_when_empty(self): family = Family.objects.create()