diff --git a/management/context_processors.py b/management/context_processors.py index 05d4dd0..a1d77a4 100644 --- a/management/context_processors.py +++ b/management/context_processors.py @@ -126,6 +126,7 @@ _NAV_SECTIONS = { "invoice_list": "invoice_list", "form_list": "form_list", "submission_list": "form_list", + "evaluations": "evaluations", "club_settings": "club_settings", "onboarding_requirement_list": "onboarding_requirement_list", "onboarding_requirement_create": "onboarding_requirement_list", @@ -171,6 +172,7 @@ _TOP_SECTION = { "discount_list": "finance", "invoice_list": "finance", "form_list": "settings", + "evaluations": "settings", "club_settings": "settings", "onboarding_requirement_list": "settings", "role_list": "settings", diff --git a/management/templates/management/_nav_items.html b/management/templates/management/_nav_items.html index 902596c..f85ca98 100644 --- a/management/templates/management/_nav_items.html +++ b/management/templates/management/_nav_items.html @@ -100,6 +100,12 @@ {% trans "Positions" %} {% endif %} {% trans "Referee levels" %} + {% comment %} + Deliberately not behind a waffle flag like Forms above -- this is a standing + "not built yet" reminder, so it stays visible rather than disappearing until + someone remembers to flip a flag on. See management.views.EvaluationsComingSoonView. + {% endcomment %} + {% trans "Evaluations" %} {% trans "Soon" %} {% if is_club_admin %} {% if forms_enabled %} {% trans "Forms" %} diff --git a/management/tests.py b/management/tests.py index a484d63..0bccba4 100644 --- a/management/tests.py +++ b/management/tests.py @@ -6716,6 +6716,42 @@ class FeatureGatedSectionsTests(ManagementTestBase): self.assertNotContains(response, "Forms") +class EvaluationsComingSoonViewTests(ManagementTestBase): + """Placeholder nav entry/page for player evaluations (design: ARCHITECTURE.md + §5.8) -- see management.views.EvaluationsComingSoonView.""" + + def make_plain_staff(self, email="physio-eval@example.com"): + staff_user = User.objects.create_user(email=email, password="pw-secret-123") + staff_member = Member.objects.create(user=staff_user, first_name="Pat", last_name="Physio") + ClubMembership.objects.create(club=self.club, member=staff_member, season=self.season, status=ClubMembership.StatusChoices.ACTIVE) + team = Team.objects.create(club=self.club, name="Physio Team", short_name="PHY") + position = Position.objects.create(club=self.club, name="Physio", short_name="PH", staff_position=True, management_position=False) + StaffAssignment.objects.create(team=team, member=staff_member, season=self.season, position=position) + return staff_user + + def test_member_admin_can_reach_it(self): + self.client.force_login(self.admin_user) + + response = self.club_get("evaluations") + + self.assertEqual(response.status_code, 200) + self.assertContains(response, "Player evaluations") + + def test_plain_staff_gets_403(self): + self.client.force_login(self.make_plain_staff()) + + response = self.club_get("evaluations") + + self.assertEqual(response.status_code, 403) + + def test_nav_shows_the_placeholder_unconditionally_no_flag_needed(self): + self.client.force_login(self.admin_user) + + response = self.club_get("club_settings") + + self.assertContains(response, "Evaluations") + + RBIHF_SAMPLE_HTML = """

Sportoase Antwerp Phantoms

Upcoming games

diff --git a/management/urls.py b/management/urls.py index 0694b64..8f5d72f 100644 --- a/management/urls.py +++ b/management/urls.py @@ -135,6 +135,8 @@ urlpatterns = [ # Forms path("forms/", views.FormListView.as_view(), name="form_list"), path("forms//submissions/", views.SubmissionListView.as_view(), name="submission_list"), + # Evaluations (placeholder -- see ARCHITECTURE.md §5.8, nothing built yet) + path("evaluations/", views.EvaluationsComingSoonView.as_view(), name="evaluations"), # Settings (admin only) path("settings/", views.ClubSettingsView.as_view(), name="club_settings"), path("settings/email-previews//render/", views.EmailPreviewRenderView.as_view(), name="email_preview_render"), diff --git a/management/views.py b/management/views.py index fed7131..636b6ee 100644 --- a/management/views.py +++ b/management/views.py @@ -3405,6 +3405,22 @@ class SubmissionListView(FeatureRequiredMixin, StubListMixin, ListView): return Submission.objects.filter(form__club=self.request.club, form_id=self.kwargs["pk"]) +class EvaluationsComingSoonView(MemberAdminRequiredMixin, TemplateView): + """Placeholder nav entry for player evaluations (design: ARCHITECTURE.md + §5.8) -- nothing else is built yet. Deliberately *not* a FeatureRequiredMixin/ + waffle-flagged stub like the shop/forms sections above: those hide their nav + item until a platform operator turns the flag on for a club, which is exactly + wrong for a standing "don't forget to build this" reminder -- this stays + visible to every MEMBER_ADMIN/ADMIN on every club unconditionally. Reuses + _generic_list.html (StubListMixin's own template) with an empty object_list + rather than a real queryset, since there's no model behind this yet at all.""" + + template_name = "management/_generic_list.html" + + def get_context_data(self, **kwargs): + return super().get_context_data(page_title=_("Player evaluations"), object_list=[], **kwargs) + + class ClubSettingsView(ClubAdminRequiredMixin, UpdateView): """A club's own self-service identity/branding editor -- the "Club identity" settings sub-item. Singleton by construction: always edits request.club, never