bernard/RosterChief
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Show a News empty state on Home instead of hiding the card

Browse Source 
Previously the whole "Club news" card just vanished when there was
nothing to show, dropping the "All news" link along with it. Now it
always renders -- either the real teaser or a "No news yet" card, still
linking through to mobile:news_list either way.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ECGMEwrc2k4D8VQuwjstj9
This commit is contained in:
Bernard Siebens
2026-08-21 16:09:15 +02:00
parent 5096d0ba05
commit 40bee9af48
2 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
mobile/templates/mobile/home.html
View File

@@ -126,12 +126,12 @@
</div> </div>
{% endif %} {% endif %}
{% if news_items %} <div>
<div> <div class="mb-2.5 flex items-baseline justify-between">
<div class="mb-2.5 flex items-baseline justify-between"> <span class="font-display text-xs font-extrabold text-muted uppercase tracking-wide">{% trans "Club news" %}</span>
<span class="font-display text-xs font-extrabold text-muted uppercase tracking-wide">{% trans "Club news" %}</span> <a class="text-xs font-semibold text-club" href="{% url "mobile:news_list" %}">{% trans "All news" %}</a>
<a class="text-xs font-semibold text-club" href="{% url "mobile:news_list" %}">{% trans "All news" %}</a> </div>
</div> {% if news_items %}
{% with lead=news_items.0 %} {% with lead=news_items.0 %}
<a class="m-card block overflow-hidden" href="{% url "mobile:news_detail" lead.slug %}"> <a class="m-card block overflow-hidden" href="{% url "mobile:news_detail" lead.slug %}">
<div class="flex h-[104px] items-center justify-center bg-line text-xs text-dim">{% trans "News photo" %}</div> <div class="flex h-[104px] items-center justify-center bg-line text-xs text-dim">{% trans "News photo" %}</div>
@@ -156,10 +156,14 @@
{% endfor %} {% endfor %}
</div> </div>
{% endif %} {% endif %}
</div> {% else %}
{% endif %} <div class="m-card p-6 text-center">
<p class="text-sm text-muted">{% trans "No news yet." %}</p>
</div>
{% endif %}
</div>
{% if not hero_attendance and not needs_answer and not dues_rows and not news_items %} {% if not hero_attendance and not needs_answer and not dues_rows %}
<div class="m-card p-6 text-center"> <div class="m-card p-6 text-center">
<p class="text-sm text-muted">{% trans "Nothing to show right now." %}</p> <p class="text-sm text-muted">{% trans "Nothing to show right now." %}</p>
</div> </div>

9
mobile/tests.py
View File

@@ -326,6 +326,15 @@ class HomeViewTests(TestCase):
self.assertEqual(list(response.context["news_items"]), []) self.assertEqual(list(response.context["news_items"]), [])
def test_news_card_shows_an_empty_state_with_a_link_to_all_news_when_there_is_none(self):
self.client.force_login(self.user)
response = self._get("home")
self.assertEqual(list(response.context["news_items"]), [])
self.assertContains(response, "No news yet.")
self.assertContains(response, 'href="/app/news/"')
def test_empty_account_gets_a_graceful_empty_state(self): def test_empty_account_gets_a_graceful_empty_state(self):
bare_user = User.objects.create_user(email="new@example.com", password="pw-secret-123") bare_user = User.objects.create_user(email="new@example.com", password="pw-secret-123")
self.client.force_login(bare_user) self.client.force_login(bare_user)