diff --git a/management/context_processors.py b/management/context_processors.py index a1d77a4..8afe36f 100644 --- a/management/context_processors.py +++ b/management/context_processors.py @@ -159,6 +159,7 @@ _TOP_SECTION = { "family_list": "members", "parent_claim_list": "members", "group_list": "members", + "evaluations": "members", "membership_list": "finance", "team_list": "teams", "referee_list": "teams", @@ -172,7 +173,6 @@ _TOP_SECTION = { "discount_list": "finance", "invoice_list": "finance", "form_list": "settings", - "evaluations": "settings", "club_settings": "settings", "onboarding_requirement_list": "settings", "role_list": "settings", diff --git a/management/templates/management/_nav_items.html b/management/templates/management/_nav_items.html index f85ca98..c9d8246 100644 --- a/management/templates/management/_nav_items.html +++ b/management/templates/management/_nav_items.html @@ -32,6 +32,14 @@ {% trans "Households" %} {% if can_manage_members %} {% trans "Groups" %} + {% comment %} + Placeholder -- nothing else is built yet (see ARCHITECTURE.md ยง5.8 and + management.views.EvaluationsComingSoonView). Deliberately not behind a + waffle flag like Forms below -- this is a standing "not built yet" + reminder, so it stays visible rather than disappearing until someone + remembers to flip a flag on. + {% endcomment %} + {% trans "Evaluations" %} {% trans "Soon" %} {% endif %} {% endif %} @@ -100,12 +108,6 @@ {% trans "Positions" %} {% endif %} {% trans "Referee levels" %} - {% comment %} - Deliberately not behind a waffle flag like Forms above -- this is a standing - "not built yet" reminder, so it stays visible rather than disappearing until - someone remembers to flip a flag on. See management.views.EvaluationsComingSoonView. - {% endcomment %} - {% trans "Evaluations" %} {% trans "Soon" %} {% if is_club_admin %} {% if forms_enabled %} {% trans "Forms" %} diff --git a/management/tests.py b/management/tests.py index 0bccba4..94e1100 100644 --- a/management/tests.py +++ b/management/tests.py @@ -6747,7 +6747,7 @@ class EvaluationsComingSoonViewTests(ManagementTestBase): def test_nav_shows_the_placeholder_unconditionally_no_flag_needed(self): self.client.force_login(self.admin_user) - response = self.club_get("club_settings") + response = self.club_get("member_list") self.assertContains(response, "Evaluations")