bernard/RosterChief
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a reusable notification system; wire it into news publishing

Browse Source 
New `notifications` app: Notification (club-scoped, keyed to the
member it's about, generic `source` via a ContentType/object_id pair
so future activities can reuse this without a new model each time)
plus notify_members(), which resolves each member's own email (if
they hold a login) and every parent/guardian's, always -- a child
with their own account doesn't opt their parents out -- and emails
the club-branded template to whichever addresses that resolves to.
Delivery is email-only for now (no in-app feed exists yet); the row
is created either way, ready for one later.

news.tasks.notify_news_published resolves the audience (a team-scoped
item's current rosters, or every active member if it's club-wide) and
calls notify_members with the item's title/plain-text body.
NewsPublishForm gained a "Notify linked members" checkbox (opt-in,
default off); when checked, NewsPublishView schedules the task with
Celery's `eta` set to the item's own published_at -- a scheduled
item's notification arrives when it actually goes live, and an
immediate publish (eta in the past) just runs right away, no separate
branch needed.

Registered the new notification email on the Club identity page's
Email tab alongside the others.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ECGMEwrc2k4D8VQuwjstj9
This commit is contained in:
Bernard Siebens
2026-08-21 09:27:55 +02:00
parent 916f9bf8ab
commit 5f7ca98eae
19 changed files with 616 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
management/tests.py
View File

@@ -4145,6 +4145,33 @@ class NewsManagementTests(ManagementTestBase):
item.refresh_from_db()
self.assertFalse(item.is_scheduled)
def test_notify_members_checkbox_emails_the_audience(self):
member = Member.objects.create(first_name="Jamie", last_name="Doe", email="jamie@example.com")
ClubMembership.objects.create(club=self.club, member=member, season=self.season, status=ClubMembership.StatusChoices.ACTIVE)
User.objects.create_user(email="jamie@example.com", password="pw-secret-123")
member.user = User.objects.get(email="jamie@example.com")
member.save(update_fields=["user"])
item = News.objects.create(club=self.club, title="Draft item", body="Body.")
self.client.force_login(self.editor)
self.club_post("news_publish", {"published_at": timezone.now().strftime("%Y-%m-%dT%H:%M"), "notify_members": "on"}, item.pk)
# Not asserting an exact outbox size: the base fixture's own staff
# members (self.editor etc.) may also be active MEMBER-kind club
# members in this same season, so they legitimately get one too.
sent_to = [address for message in mail.outbox for address in message.to]
self.assertIn("jamie@example.com", sent_to)
def test_leaving_notify_members_unchecked_sends_nothing(self):
member = Member.objects.create(first_name="Jamie", last_name="Doe", email="jamie@example.com")
ClubMembership.objects.create(club=self.club, member=member, season=self.season, status=ClubMembership.StatusChoices.ACTIVE)
item = News.objects.create(club=self.club, title="Draft item", body="Body.")
self.client.force_login(self.editor)
self.club_post("news_publish", {"published_at": timezone.now().strftime("%Y-%m-%dT%H:%M")}, item.pk)
self.assertEqual(len(mail.outbox), 0)
def test_unpublishing_reverts_to_draft(self):
item = News.objects.create(club=self.club, title="Live item", body="Body.")
item.publish()