From 638f85fa07f0770d0c5d679cbae6e0eba9aa405b Mon Sep 17 00:00:00 2001 From: Bernard Siebens Date: Sun, 12 Jul 2026 00:21:48 +0200 Subject: [PATCH] Remove redundant user re-link branch in CSV importer update_or_create already persists member.user via defaults, so the follow-up `if create_account and member.user_id is None` block was unreachable dead code. Removing it brings importer coverage to 100% with no behavior change (existing link-existing-user test still passes). Co-Authored-By: Claude Opus 4.8 --- members/services/member_csv_importer.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/members/services/member_csv_importer.py b/members/services/member_csv_importer.py index 508c289..2443c09 100644 --- a/members/services/member_csv_importer.py +++ b/members/services/member_csv_importer.py @@ -127,10 +127,6 @@ class MemberCsvImporter: }, ) - if create_account and member.user_id is None: - member.user = user - member.save(update_fields=["user"]) - club, club_created = Club.objects.get_or_create(name=club_name) _, membership_created = ClubMembership.objects.update_or_create(