bernard/RosterChief
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Season-scope claim history, self-service second-child claims, redesign approval screen

Browse Source 
Signed-in parents get their details locked and pre-filled on the claim
form instead of retyped; approving links to their existing user and
merges into their existing family instead of creating a duplicate.
The approval screen is now a card grid with a searchable, pre-selected
child dropdown and a reason modal for rejection. The "already dealt
with" history is scoped to the current season.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Bernard Siebens
2026-08-11 23:52:50 +02:00
parent b2657bb15d
commit c4f0ec71c1
11 changed files with 445 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
members/services/family.py
View File

@@ -133,12 +133,20 @@ def add_child_to_family(club, season, family, *, first_name, last_name, date_of_
@transaction.atomic
def add_parent_to_family(club, season, family, *, email, first_name="", last_name="", parent_is_member=False):
def add_parent_to_family(club, season, family, *, email="", first_name="", last_name="", parent_is_member=False, parent=None):
"""A family that needs one more parent/guardian registered. A guardian
unless ``parent_is_member`` says they belong to the club in their own right."""
parent = get_or_create_login_member(email, first_name, last_name)
# get_or_create, not create: re-adding an email already on this family (a typo'd
# re-submit, say) must not trip unique_member_per_family.
unless ``parent_is_member`` says they belong to the club in their own right.
``parent`` lets a caller that already knows the Member (e.g.
members.services.claims.approve_claim, once a claim carries a signed-in
submitter) attach them directly instead of resolving ``email`` again --
authoritative when the caller has it, and the only way to guarantee no
second User/Member is ever created for the same person.
"""
if parent is None:
parent = get_or_create_login_member(email, first_name, last_name)
# get_or_create, not create: re-adding a parent already on this family (a typo'd
# re-submit, or a second claim that merged into it) must not trip unique_member_per_family.
FamilyMembership.objects.get_or_create(family=family, member=parent, defaults={"role": FamilyMembership.FamilyRole.PARENT})
_enrol(club, season, parent, kind=ClubMembership.Kind.MEMBER if parent_is_member else ClubMembership.Kind.GUARDIAN)