Add parent claims: onboarding a roster of children with no parents on file

The migration path for a club arriving with a list of children from a
federation export and no parent records. Children import without logins, each
into a family of their own -- that shape *is* the "nobody is responsible for
this child" state, so there's no unclaimed flag to drift out of step with
reality, and a family drops off the worklist by itself the moment a parent
joins it. `family_role=child` with a blank `family_group` asks for that; any
other lone role is still a mistake in the file.

Verification is a human decision, deliberately. A parent submits a public form
with the child's name and date of birth as free text -- no search, no
autocomplete, and the same response whether or not the child was found, because
the page needs no login and anything that resolved the child would turn it into
a way to enumerate the club's children. An admin matches it from a queue
against a shortlist that only ever contains children with nobody on file, so
approving can never quietly re-parent a child who already has one.

The alternatives were worse. A claim code needs a delivery channel the club may
not have and is a bearer token besides. Matching on name plus birthday hands out
someone else's child to whoever guesses a birthday. The club is the only party
that actually knows its own families.

That form is also the registration: open self-registration is now closed
(shadowing account_signup rather than removing the route, so the URL name
allauth's templates reverse still resolves). The account is created on
approval, not on submission, so a public form can't fill the user table. An
approved parent lands as a guardian -- login and family link, no membership, no
fee -- gets a password-reset link, and a minimal "my family" page.

One bug worth recording: families_awaiting_a_parent first used
annotate(Count(..., filter=...)) over a queryset already filtered on the same
join, so Django reused that join for the counts and a parent with no
ClubMembership of their own -- exactly what a newly linked guardian is -- went
uncounted, leaving the family unclaimed forever. Exists subqueries avoid it. A
test pins both directions.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-11 18:18:26 +02:00
parent 744b623403
commit ca2b1a11b5
25 changed files with 1033 additions and 10 deletions

View File

@@ -423,6 +423,33 @@ ClubMembership(ClubScopedModel) # -> carries `club`
a parent exactly like the child, so every parent counted as a member — a data migration
reclassifies them, deliberately skipping anyone who plays, is on a team's staff, or holds
an elevated ClubRole.
- **Onboarding a legacy roster: `members.ParentClaim`** *(built)*. The migration path for a
club that arrives with a list of children and no parent records at all. Children import
without logins, each into a **family of their own** — that shape *is* the "nobody is
responsible for this child" state (`members/services/claims.py::families_awaiting_a_parent`),
so there is no flag to drift out of step with reality, and the family drops off the worklist
by itself the moment a parent joins it. `family_role=child` with a blank `family_group` is
what asks for it; any other lone role is still a mistake in the file.
- **Verification is a human decision, deliberately.** A parent submits a public form
(`/claim/`) with the child's name and date of birth as **free text — no search, no
autocomplete, no confirmation of whether the child was found**, because the page is
reachable without logging in and anything that resolved the child would turn it into a way
to enumerate the club's children. An admin matches it from a queue against a shortlist that
only ever contains children with nobody on file, so approving can never quietly re-parent a
child who already has one. The alternatives were rejected: a claim code needs a delivery
channel the club may not have, and matching on name plus birthday hands out someone else's
child to whoever guesses a birthday.
- **The claim form is also the registration.** Open self-registration is closed
(`club.views.signup_closed` shadows `account_signup` rather than removing the route, so the
URL name allauth's own templates reverse still resolves). Accounts are created by an admin,
by the family-registration form, or on claim approval — never by a stranger, which also
keeps the review queue from being a spam target. The account is created **on approval**, not
on submission, so a public form can't fill the user table.
- **An approved parent lands as a guardian**, with the login and the family link but no
membership and no fee. If they also play, an admin flips `kind` on their membership
afterwards; approving a claim is not the place to decide it. They then get a password-reset
link and a minimal "my family" page (`members/views.py::MyFamilyView`) — the seam a real
parent portal would grow from.
- **Why a field and not a separate model.** Everything that answers "is this person attached
to this club" already reads through `ClubMembership` — tenancy scoping, group membership,
the club-wide event audience — and a second kind of link would need a parallel path through