Email a set-password link on claim approval, flash identically either way

Two additions to the parent-claim flow: Club.contact_email (set from the
control panel, next to legal_name), and an email sent when an admin approves a
claim -- a real one-time set-password link built with allauth's own token
generator, so it lands in the same flow the login page's own reset would send
a parent to rather than a second, parallel one that could drift out of step
with it.

Never allowed to fail the approval: the family link and the guardian row are
real either way, and a mail server being briefly unreachable must not cost a
parent their place in the queue. The admin gets a distinct warning telling
them the email didn't go and to have the parent use "Forgot your password?"
instead.

The public submission flash keeps the enumeration guarantee the claim form
itself was built around: worded and timed identically whether or not a
matching child was found, sent before any lookup happens at all, mentioning
the club's contact email when the club has set one. A test compares the
rendered flash across a matching and a non-matching submission byte for byte.

One test-writing trap worth recording: assertRedirects follows the redirect
itself by default, and its own probe GET consumed the one-shot flash message
before a later explicit GET in the same test could see it --
fetch_redirect_response=False avoids the double-fetch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-11 18:33:41 +02:00
parent ca2b1a11b5
commit cb7f56709b
12 changed files with 186 additions and 35 deletions

View File

@@ -450,6 +450,22 @@ ClubMembership(ClubScopedModel) # -> carries `club`
afterwards; approving a claim is not the place to decide it. They then get a password-reset
link and a minimal "my family" page (`members/views.py::MyFamilyView`) — the seam a real
parent portal would grow from.
- **`Club.contact_email`** *(built)* — the club's own public address, set from the control
panel next to `legal_name`. Shown to the parent both in the submission flash and in the
approval email, as somewhere to write if something's wrong — falls back to nothing shown at
all when unset, same pattern as `legal_name`/`official_name`.
- **The flash after submitting is worded and timed to reveal nothing.** Sent *before* any
lookup happens, from a fixed string that never varies with whether a matching child was
actually found (`members/views.py::ParentClaimView.form_valid`) — a message that differed
would be exactly the enumeration channel free-text matching was built to avoid.
- **Approval emails a real one-time set-password link**, built with allauth's own token
generator (`default_token_generator`/`user_pk_to_url_str`) so it lands in the same flow the
login page's own reset would send them to, rather than a second, parallel one that could
drift out of step with it. Sending is never allowed to fail the approval — the family link
and the guardian row are real either way, and a briefly unreachable mail server must not
cost the parent their place in the queue; the admin sees a distinct warning message
(`management/views.py::ParentClaimApproveView`) telling them the email didn't go and to have
the parent use "Forgot your password?" instead.
- **Why a field and not a separate model.** Everything that answers "is this person attached
to this club" already reads through `ClubMembership` — tenancy scoping, group membership,
the club-wide event audience — and a second kind of link would need a parallel path through