bernard/RosterChief
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix flaky this-week/next-week grouping tests around the evening boundary

Browse Source 
Both fixtures anchored their "this week" event at a hardcoded 18:00 on the
last day of the current week -- fine any other day, but once the suite runs
past 18:00 on that day itself, the anchor is already in the past and the
view's own start__gte=now filter correctly excludes it, failing the test
for a reason that has nothing to do with the grouping logic being tested.
Falls back to "a few minutes from now" (still always this week) whenever
the fixed anchor would already be behind now.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Bernard Siebens
2026-08-23 18:07:47 +02:00
parent 8c415ed46a
commit eb37ed187e
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
management/tests.py
View File

@@ -5611,7 +5611,15 @@ class EventManagementTests(ManagementTestBase):
# Mirrors mobile.views.CalendarView's own This week/Next week/by-month
# agenda grouping -- see EventListView._list_groups.
_this_week_start, this_week_end = week_bounds(timezone.localdate())
this_week_event = Event.objects.create(club=self.club, title="This week event", start=timezone.make_aware(datetime.datetime.combine(this_week_end, datetime.time(18, 0))))
this_week_event_start = timezone.make_aware(datetime.datetime.combine(this_week_end, datetime.time(18, 0)))
if this_week_event_start <= timezone.now():
# The fixed 18:00 anchor is only "this week" if it's still ahead of
# now -- when this_week_end is today and it's already past 18:00,
# fall back to a few minutes from now (still always this week)
# instead of a start the view's own start__gte=now filter would
# exclude as already past.
this_week_event_start = timezone.now() + datetime.timedelta(minutes=5)
this_week_event = Event.objects.create(club=self.club, title="This week event", start=this_week_event_start)
this_week_event.teams.add(self.own_team)
next_week_event = Event.objects.create(club=self.club, title="Next week event", start=timezone.make_aware(datetime.datetime.combine(this_week_end + datetime.timedelta(days=3), datetime.time(18, 0))))
next_week_event.teams.add(self.own_team)