Move the Evaluations placeholder nav entry to Members
Fits better next to Groups/Households than under Settings -- it's about people, not club configuration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ECGMEwrc2k4D8VQuwjstj9
This commit is contained in:
@@ -159,6 +159,7 @@ _TOP_SECTION = {
|
|||||||
"family_list": "members",
|
"family_list": "members",
|
||||||
"parent_claim_list": "members",
|
"parent_claim_list": "members",
|
||||||
"group_list": "members",
|
"group_list": "members",
|
||||||
|
"evaluations": "members",
|
||||||
"membership_list": "finance",
|
"membership_list": "finance",
|
||||||
"team_list": "teams",
|
"team_list": "teams",
|
||||||
"referee_list": "teams",
|
"referee_list": "teams",
|
||||||
@@ -172,7 +173,6 @@ _TOP_SECTION = {
|
|||||||
"discount_list": "finance",
|
"discount_list": "finance",
|
||||||
"invoice_list": "finance",
|
"invoice_list": "finance",
|
||||||
"form_list": "settings",
|
"form_list": "settings",
|
||||||
"evaluations": "settings",
|
|
||||||
"club_settings": "settings",
|
"club_settings": "settings",
|
||||||
"onboarding_requirement_list": "settings",
|
"onboarding_requirement_list": "settings",
|
||||||
"role_list": "settings",
|
"role_list": "settings",
|
||||||
|
|||||||
@@ -32,6 +32,14 @@
|
|||||||
<a class="nav-subitem {% if nav == 'family_list' %}active{% endif %}" href="{% url 'management:family_list' %}">{% trans "Households" %}</a>
|
<a class="nav-subitem {% if nav == 'family_list' %}active{% endif %}" href="{% url 'management:family_list' %}">{% trans "Households" %}</a>
|
||||||
{% if can_manage_members %}
|
{% if can_manage_members %}
|
||||||
<a class="nav-subitem {% if nav == 'group_list' %}active{% endif %}" href="{% url 'management:group_list' %}">{% trans "Groups" %}</a>
|
<a class="nav-subitem {% if nav == 'group_list' %}active{% endif %}" href="{% url 'management:group_list' %}">{% trans "Groups" %}</a>
|
||||||
|
{% comment %}
|
||||||
|
Placeholder -- nothing else is built yet (see ARCHITECTURE.md §5.8 and
|
||||||
|
management.views.EvaluationsComingSoonView). Deliberately not behind a
|
||||||
|
waffle flag like Forms below -- this is a standing "not built yet"
|
||||||
|
reminder, so it stays visible rather than disappearing until someone
|
||||||
|
remembers to flip a flag on.
|
||||||
|
{% endcomment %}
|
||||||
|
<a class="nav-subitem flex items-center gap-1.5 {% if nav == 'evaluations' %}active{% endif %}" href="{% url 'management:evaluations' %}">{% trans "Evaluations" %} <span class="badge badge-neutral badge-xs">{% trans "Soon" %}</span></a>
|
||||||
{% endif %}
|
{% endif %}
|
||||||
</div>
|
</div>
|
||||||
{% endif %}
|
{% endif %}
|
||||||
@@ -100,12 +108,6 @@
|
|||||||
<a class="nav-subitem {% if nav == 'position_list' %}active{% endif %}" href="{% url 'management:position_list' %}">{% trans "Positions" %}</a>
|
<a class="nav-subitem {% if nav == 'position_list' %}active{% endif %}" href="{% url 'management:position_list' %}">{% trans "Positions" %}</a>
|
||||||
{% endif %}
|
{% endif %}
|
||||||
<a class="nav-subitem {% if nav == 'referee_level_list' %}active{% endif %}" href="{% url 'management:referee_level_list' %}">{% trans "Referee levels" %}</a>
|
<a class="nav-subitem {% if nav == 'referee_level_list' %}active{% endif %}" href="{% url 'management:referee_level_list' %}">{% trans "Referee levels" %}</a>
|
||||||
{% comment %}
|
|
||||||
Deliberately not behind a waffle flag like Forms above -- this is a standing
|
|
||||||
"not built yet" reminder, so it stays visible rather than disappearing until
|
|
||||||
someone remembers to flip a flag on. See management.views.EvaluationsComingSoonView.
|
|
||||||
{% endcomment %}
|
|
||||||
<a class="nav-subitem flex items-center gap-1.5 {% if nav == 'evaluations' %}active{% endif %}" href="{% url 'management:evaluations' %}">{% trans "Evaluations" %} <span class="badge badge-neutral badge-xs">{% trans "Soon" %}</span></a>
|
|
||||||
{% if is_club_admin %}
|
{% if is_club_admin %}
|
||||||
{% if forms_enabled %}
|
{% if forms_enabled %}
|
||||||
<a class="nav-subitem {% if nav == 'form_list' %}active{% endif %}" href="{% url 'management:form_list' %}">{% trans "Forms" %}</a>
|
<a class="nav-subitem {% if nav == 'form_list' %}active{% endif %}" href="{% url 'management:form_list' %}">{% trans "Forms" %}</a>
|
||||||
|
|||||||
@@ -6747,7 +6747,7 @@ class EvaluationsComingSoonViewTests(ManagementTestBase):
|
|||||||
def test_nav_shows_the_placeholder_unconditionally_no_flag_needed(self):
|
def test_nav_shows_the_placeholder_unconditionally_no_flag_needed(self):
|
||||||
self.client.force_login(self.admin_user)
|
self.client.force_login(self.admin_user)
|
||||||
|
|
||||||
response = self.club_get("club_settings")
|
response = self.club_get("member_list")
|
||||||
|
|
||||||
self.assertContains(response, "Evaluations")
|
self.assertContains(response, "Evaluations")
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user